search

wp-shortcake / shortcake-bakery

A fine selection of shortcodes for WordPress
42 stars 16 forks source link

shortcode-ui.render_destroy from Shortcake plugin is not being fired. #219

Closed desaiuditd closed 6 years ago

desaiuditd commented 6 years ago

insertAction method for WP Post media frame is being overridden.

And because of that the default event shortcode-ui.render_destroy from Core Shortcake plugin is not being fired.

Ref:

https://github.com/wp-shortcake/shortcake/commit/f7364a30f1ef4b1b8fe848fbade866950d21c349#diff-e896f34e64a0875262f930016b24aee8R126

https://github.com/wp-shortcake/shortcake-bakery/commit/a77b4062d12fa5dd676f0476a54b4a89dcaa9ef7#diff-ab3cd71f9dd659dda2e8239ccabe433eR180

desaiuditd commented 6 years ago

This is happening when we use Shortcake UI and Shortcake Bakery plugins at the same time.

desaiuditd commented 6 years ago

Based on the discussion with @goldenapples we can remove the insertAction to allow doAction from the parent object method itself.