search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
664 stars 143 forks source link

Update Select2 from 3.5.2 to 4.0.3 (or add compat) #646

Closed westonruter closed 7 years ago

westonruter commented 7 years ago

The Customize Posts plugin includes Select2 4.0.3 and it seems that Shortcake is calling a Select2 method that no longer available: https://wordpress.org/support/topic/conflict-with-shortcake-ui/

So can Select2 be upgraded in Shortcake? Or can Shortcake add compatibility for v4?

goldenapples commented 7 years ago

Seems like the main thing we'll need to rewrite for this to work on Select2 4.0.3 is the initSelection method used to set the initial data values of the attribute fields which are rendered with select2 elements.

Since that method has been removed in the latest Select2, we'll need to override the current method of the data adapter to properly set the selected options.

goldenapples commented 7 years ago

Fixed in latest version.