search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
664 stars 143 forks source link

Use post params to build ajax endpoint rather than string concatenation #653

Closed goldenapples closed 7 years ago

goldenapples commented 7 years ago

Rather than building the admin-ajax url to post a bulk preview request to, use a post parameter to specify the action.

Adds compatability with WPML and other plugins which filter the admin-ajax url to add additional query string parameters to it. Also, it seems like better practice to use request parameters rather than concatenating strings to build urls.

An alternate approach to #568

goldenapples commented 7 years ago

ready for review/merge here.

mattheu commented 7 years ago

👍