search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
664 stars 142 forks source link

Add node-sass as devDependency to fix grunt-sass #685

Closed westonruter closed 7 years ago

westonruter commented 7 years ago

Fixes grunt builds. Without this I would get:

Warning: Task "sass" not found. Use --force to continue. Error: Task "sass" not found.

westonruter commented 7 years ago

Build fails due to new i18n sniff doing what it should! https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/742

goldenapples commented 7 years ago

This surprises me, because node-sass is in the dependency tree for grunt-sass so it should be getting built already.

Also, the sass task is provided by grunt-sass, so if you're getting the Task "sass" not found message, that would seem to indicate that grunt-sass hadn't been initialized in the first place.

I'll see if I can reproduce the npm install / grunt problem and merge if so.

goldenapples commented 7 years ago

I found out this is required when rebuilding my Linux dev machine this morning (I'm not sure why I never came across it before, other than possibly have node-sass installed globally).

I'll merge this to save other people the trouble of having to discover this.