search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
664 stars 143 forks source link

Percent replacement only does first replacement #719

Closed cooms13 closed 7 years ago

cooms13 commented 7 years ago

The line of code that I changed originally had a replacement for percent signs, but it only replaces the first instance. The change proposed does a regex replacement so that it changes all percents.

goldenapples commented 7 years ago

This is a good catch, as the intention back in #644 was definitely to allow any number of percent characters in attributes.

I'll merge this, and we can get it into the next release.