search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
664 stars 142 forks source link

Update plugin version #727

Closed edwinsiebel closed 7 years ago

edwinsiebel commented 7 years ago

The SHORTCODE_UI_VERSION should also be updated accordingly, to cache bust the affected javascript file(s) in the latest version (0.7.2).

szepeviktor commented 7 years ago

Good catch!

edwinsiebel commented 7 years ago

Glad to help.

Will you be commiting the fix to the WordPress repo soon? Then we can update our sites using the plugin, without clients needing to cleanup their cache files.

szepeviktor commented 7 years ago

@goldenapples has access to that

goldenapples commented 7 years ago

Thanks for catching this. I can push it to the repo later today, but unless the version number is bumped again, it won't show as an automatic update, so I'm not sure if it'll fix the problem for end users. We'll have to release as 0.7.3 I believe.

edwinsiebel commented 7 years ago

We pull it in via wpackagist so I guess that will work for us, however no for all the other who work via automatic updates. Guess a version bump will be necessary.

Don't forget to update the SHORTCODE_UI_VERSION as well :cheeky:

szepeviktor commented 7 years ago

We'll have to release as 0.7.3 I believe.

Maybe we could modify the current tag and and trunk.

edwinsiebel commented 7 years ago

Maybe we could modify the tag's and and trunk's source.

That could be worth the try.

goldenapples commented 7 years ago

I'll give that a shot. It won't register as an auto-update for users who have already updated to 0.7.2, but it will make any new updates bust the browser caches automatically.

goldenapples commented 7 years ago

This is updated in the plugin repository now: https://plugins.trac.wordpress.org/changeset/1649978/

edwinsiebel commented 7 years ago

@goldenapples, thanks that worked perfect for us!