search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
665 stars 143 forks source link

Fixed issue with menu click event not being delegated #737

Closed mviggiano closed 7 years ago

mviggiano commented 7 years ago

The Post Media Frame's click event was not being delegated properly. This was causing the menu to not respond to clicks and therefore not drop down in narrow-viewport scenarios. The issue was being caused by code in media-frame.js returning a function rather than an object for the events property of the mediaFrame object.

Most of the tweaks in this PR aren't mine - they appeared to be preexisting differences between the src and build that were compiled to build by my running of grunt (probably a version difference). The only changes I made were to the events property - the last two diffs.

davisshaver commented 7 years ago

Hey @mviggiano! Thanks for the contribution. I was able to recreate the branch with current npm install and I tested it locally so I think we are good to merge. Good fix!

szepeviktor commented 7 years ago

What is the relation of this repo to alleyinteractive/shortcake?