search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
665 stars 143 forks source link

Set active editor #746

Closed mattheu closed 6 years ago

mattheu commented 7 years ago

I have run into some issues when working with multiple instances of the wp editor on a page. This PR aims to track the active editor so that when you insert the shortcode it is inserted into the correct editor.

Hold off reviewing/merging this one for now - it was a quick fix for a bug we had and I wanted to track it somewhere. I'll try and put together a some better instructions to reproduce. We ran into this because we have tinyMCE field inside the shortcake edit screen.

rahulsprajapati commented 6 years ago

@mattheu is there something we need to work on this PR, can we merge this to master or add it to next release? cc: @goldenapples

mattheu commented 6 years ago

Ah yeah - i'll dust this off. We're running this branch so I forgot it wasn't wrapped up :)

goldenapples commented 6 years ago

@mattheu Hey, is this ready to merge for 0.7.3? It works for me, do you feel good about it?

goldenapples commented 6 years ago

:ship: