wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
665 stars 143 forks source link

'select' field option doesn't retain value on subsequent edits #747

Closed sudar closed 7 years ago

sudar commented 7 years ago

Steps to replicate

goldenapples commented 7 years ago

Is this happening with the current master head? It sounds like you might be coming uip against the issue that was just fixed in #745.

antek83 commented 7 years ago

It happens to me as well, for select fields with just 2/3 options it is not a big problem. If you don't count that when u edit a field it automatically shows you the first option but does not let you select It.

I've resorted in leaving the first option empty or a useless value, with a label of 'Select -whatever-' this way when reopnening a shortcode for editing the user is forced to select at least the second option and it will work. If the user does not touch it it will keep the previously selected value but it will show the text "Select" not perfect ux but better that showing a completely different option

goldenapples commented 7 years ago

Thanks for the report. Are you sure you're seeing this issue on the current master branch? I can't replicate it right now (though I did see that same problem before #745 was merged).

I'd just like to make sure this bug is fixed before cutting a new release.

ocean90 commented 7 years ago

Confirmed that it's broken in 0.7.2 but fixed in the master branch.

sudar commented 7 years ago

Even I can confirm that it is broken in 0.7.2 but fixed in master.

szepeviktor commented 7 years ago

@sudar Please try the master branch.

sudar commented 7 years ago

Any idea when the next release of the plugin (with this fix) will be made?