search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
664 stars 143 forks source link

Fix js uncaught TypeError #780

Closed angtheod closed 5 years ago

angtheod commented 6 years ago

Fix js uncaught TypeError when no options have been supplied to the field causing firstVisibleOption to be undefined. This resulted to a blank Insert Post Element popup when clicking on an element that contained such field.

goldenapples commented 6 years ago

@angtheod This looks like a good safety check to have in place. Are you able to (1) merge the latest master into this branch here, and (2) run grunt scripts to build the dist files and check them in?

angtheod commented 6 years ago

@goldenapples Hi there, sure, will do that as soon as possible

goldenapples commented 5 years ago

Merging - this fix is long overdue and should get into the next release. I'll rebuild the scripts after merging since I don't have push access to this branch.