search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
665 stars 143 forks source link

Add media close hook #797

Closed cyruscollier closed 6 years ago

cyruscollier commented 6 years ago

Addresses Issue #785.

desaiuditd commented 6 years ago

@goldenapples What event would you recommend to use on updating existing shortcode ? Would it still be render_closed?

So I think this can be merged as is - render_closed is a clear hook name, and I'll add a note in the render_destroy docblock clarifying that this hook is only run on inserting a shortcode.

desaiuditd commented 6 years ago

Apparently, while digging in further, I realised that the render_destroy not being triggered on close, could be because of https://github.com/wp-shortcake/shortcake-bakery/issues/219

https://github.com/wp-shortcake/shortcake-bakery/pull/220 solves the issue and supersedes this PR.

@goldenapples Thoughts?

goldenapples commented 6 years ago

Thanks @cyruscollier for the PR and @desaiuditd for testing... Merging this PR now.