search

wp-shortcake / shortcake

Shortcake makes using WordPress shortcodes a piece of cake.
GNU General Public License v2.0
664 stars 142 forks source link

VIP linter fixes #820

Open svandragt opened 4 years ago

svandragt commented 4 years ago

A couple of issues were highlighted by the wp linter bot.

Sanitizes unsafe $_GET['include'] use and defines $args as an empty array before using it.

Tested against ?include=12,23a, ?include[]=12&include[]=23a and without parameter.

svandragt commented 4 years ago

@goldenapples Yes you are correct I thought it would be impossible to get rid of the one remaining warning but the code as it stands doesn't raise any linter issues. Would you mind reviewing? Thanks :)