search

wp-xyz / Hex

Hex editor designed for analyzing binary files.
MIT License
55 stars 21 forks source link

[Linux] Once down arrow is pressed, arrows no longer work #7

Open gcarreno opened 2 weeks ago

gcarreno commented 2 weeks ago

Hey @wp-xyz,

If you download any of the Linux builds from: Gus Hex Releases, you'll notice that if you use the down arrow ( not tested the up arrow ), the indicator on the HEX pane goes a bit bonkers, like disappears, and then no arrow key will work again.

Minor stuff, but it's a bit annoying :stuck_out_tongue_winking_eye:

Cheers, Gus

wp-xyz commented 4 days ago

Can reproduce, but only with gtk2. No problem with qt5.

gcarreno commented 4 days ago

Hey WP(@wp-xyz),

UFFF, that's good new that you can reproduce. Thanks !!

Cheers, Gus

wp-xyz commented 4 days ago

KeyDown handler of TCustomMPHexEditor did not set handled key codes to 0. Adding Key:=0 fixes the issue (well - maybe: "works around" the issue...). My first attempt to put this at the end of KeyDown was too aggressive and broke editing features of the component. Now I added it only to the up/down key presses.

gcarreno commented 4 hours ago

Hey WP(@wp-xyz),

While doing one of the previous PRs I think I tested the most recent code and, If my memory doesn't fail me, the GTK2 version was performing as expected.

So, at least for me, this pretty much closes this issue. But if you have something else you wanna test and leave this one as a reminder, I'm good with that. If not, then please close it.

And many thanks for making the effort !!! Greatly appreciated !!

Cheers, Gus