search

wpa11yday / conference

Conference plugin; custom functionality for WP Accessibility Day
GNU General Public License v3.0
2 stars 0 forks source link

Transition captions and subtitles to plugin assets #65

Closed joedolson closed 1 month ago

joedolson commented 2 months ago

Currently, caption files are in the media library and linked from the video. It would make it easier to manage them if they were managed as assets in Github, since they are all text files. This would more easily allow us to track changes and fix issues with captions when they arise.

Structure: /assets/[year]/[session-post-slug]_[langcode].vtt

joedolson commented 1 month ago

For purely practical reasons, it makes more sense for these to live in the plugin. All of the code to execute the video player is in the plugin, and the captions will be called from the plugin, so it will be easier to pass file paths based on the plugin location. For that reason, I'm moving this to the plugin repository.

joedolson commented 1 month ago

Actual structure used: [session-post-slug]-[langcode].vtt

I was thinking I would want an underscore so I could split the string to get the language code, but I don't actually need to do that.

joedolson commented 1 month ago

This is done. Had to do it in a hurry when the videos stopped working during WPAD.