search

wpaccessibility / settings-api-enhanced

An improved WordPress Settings API with default render callbacks and a new accessible layout.
9 stars 0 forks source link

Options general: Site Language should be moved at the bottom #25

Closed afercia closed 7 years ago

afercia commented 7 years ago

The Site Language select should be moved after "Week Starts On" for parity with the current WP page. See also what is already done in #16

felixarntz commented 7 years ago

I'm not sure how you mean this. Isn't the Site Language setting displayed before Timezone, Date Format etc?

afercia commented 7 years ago

Hm this is interesting. on 4.7 (VVV http://local.wordpress.dev/) Site Language is the last setting on the page. On trunk (http://src.wordpress-develop.dev/) is before Timezone. Maybe we've missed something 🙂 and I'm not sure this change, if intentional, makes much sense. Checking.

afercia commented 7 years ago

I18N: Move "Site Language" setting above "Timezone". https://core.trac.wordpress.org/changeset/39885

This brings all locale-specific site settings closer together and prevents the language setting from being pushed down by unrelated settings added by plugins.

Hm I guess I'm OK with this, although this change forgot that a spinner is shown close to the Save Changes button only when a new language gets installed. Easy to forget because it was broken 🙂 . See https://core.trac.wordpress.org/ticket/40478