wpaccessibility / settings-api-enhanced

An improved WordPress Settings API with default render callbacks and a new accessible layout.
9 stars 0 forks source link

Fa/add reading page #31

Closed felixarntz closed 7 years ago

felixarntz commented 7 years ago

This is a PR to address #18.

Note that either this or #30 will create a merge conflict, depending on which of the two is merged first. This will need to be resolved prior to merging the second.

afercia commented 7 years ago

Everything looks good to me except a couple things: "Blog pages show at most" "Syndication feeds show the most recent" they miss the words "posts" and "items". We should avoid to add them after the selects though. Instead, we should try to reword the labels. For example something like:

"Maximum number of posts to show in the blog pages:" "Maximum number of most recent items to show in the syndication feeds:"

or even better wording, the shorter the better. Worth noting having meaningful strings (not split in two parts) would also be an improvement for translations.

Things to consider later:

felixarntz commented 7 years ago

I changed the labels to the following for now:

These labels can probably be improved, but let's use them like that for now.