search

wpaccessibility / settings-api-enhanced

An improved WordPress Settings API with default render callbacks and a new accessible layout.
9 stars 0 forks source link

Permalink settings: custom structure keyboard trap #39

Closed afercia closed 7 years ago

afercia commented 7 years ago

Noticed just know 😞 the custom structure field has the same keyboard trap that was in the General settings date/time custom format. Fixed in core in https://core.trac.wordpress.org/ticket/40515 and in this plugin in #26

For core, will open a Trac ticket.

afercia commented 7 years ago

See https://core.trac.wordpress.org/ticket/40982

felixarntz commented 7 years ago

@afercia Feel free to fix this for the WCEU Milestone if you find time tomorrow and it's an easy thing. I'd like to tag the initial version tomorrow night.

afercia commented 7 years ago

Well this still uses options_permalink_add_js() from core because there was no reason to change it so I guess better to fix it there. Fixed on trunk in https://core.trac.wordpress.org/changeset/40897