wpengine / atlas-content-modeler

Content modeling plugin for WordPress
https://developers.wpengine.com/docs/atlas-content-modeler
GNU General Public License v2.0
165 stars 13 forks source link

Deps: Update word-wrap (via optionator) #661

Closed theodesp closed 1 year ago

theodesp commented 1 year ago

Description

Set optionator overrides to v0.9.3 which fixes word-wrap vulnerability.

https://wpengine.atlassian.net/browse/

https://wpengine.atlassian.net/browse/MERL-1067

Checklist

I have:

Testing

Screenshots

Documentation Changes

Dependent PRs

mindctrl commented 1 year ago

@theodesp can you fix the conflicts here now that #660 is merged? Edit: I cancelled the e2e run since it'll need to run again anyway.

mindctrl commented 1 year ago

@theodesp I resolved the merge conflict...

update: and apparently broke things...

theodesp commented 1 year ago

I tried to re-install again and i get those errors:

Screenshot 2023-07-11 at 12 37 09

React v16 seems to have a conflict with react-test-renderer@17.0.2

I think React needs to match the version of react-test-renderer since they are incompatible:

This combination works


"react": "16.14.0",
"react-dom": "16.14.0",
"react-test-renderer": "^16.13.1",
theodesp commented 1 year ago

Closed since there is a provided fix:

https://github.com/wpengine/atlas-content-modeler/pull/664