wpengine / example-sage-theme

Modern theme development with WP Engine
20 stars 3 forks source link

Deprecated? "Add "post-autoload-dump" script..." #24

Open nathangross opened 15 hours ago

nathangross commented 15 hours ago

I noticed number 6 in docs/fresh.md references some lines of code that are no longer present in the composer.json file.

[Add "post-autoload-dump" script](https://github.com/wpengine/example-sage-theme/blob/main/wp-content/themes/your-roots-theme-name-here/composer.json#L63-L65) that'll run after every composer update command to the composer.json

Is that still necessary or was that replaced with something else? Or perhaps I'm missing something?

for ref: https://github.com/wpengine/example-sage-theme/commit/5dff83637ddf7eeb66fe603fb7dcc43ef16a54ce#diff-4c372f57ee258f33ebced6f4c9d4eece8fd08ac627ae9d0682080929d21d099eL62

nathangross commented 14 hours ago

This one might need updating too?

8. Add the github action that'll deploy the theme

wget https://github.com/wpengine/example-sage-theme/blob/main/.github/workflows/action.yml

https://github.com/wpengine/example-sage-theme/blob/main/.github/workflows/action.yml