search

wpengine / github-action-wpe-site-deploy

A GitHub Action to deploy code directly to WP Engine.
MIT License
173 stars 36 forks source link

Pipeline fails with errors #57

Closed Dimasmagadan closed 1 year ago

Dimasmagadan commented 1 year ago

Describe the bug Pipelines that use this action fail with error 'wpengine/site-deploy:1.0.0' should be either '[path]/Dockerfile' or 'docker://image[:tag]'.

To reproduce

Run pipeline that uses this action

Expected behavior

Pipeline has no errors

Version information

Dimasmagadan commented 1 year ago

had to explicitly specify older version uses: wpengine/github-action-wpe-site-deploy@v3.2.0 to make my pipelines work again

Ravavyr commented 1 year ago

Just chiming in as I'm experiencing the same issue. I've also switched my version to 3.2.0 in order to get things working again for now.

apmatthews commented 1 year ago

Thanks for the report! We've seen successful deploys with v3.2.1, so my hunch is that results may vary based on which runner is handling the action.

Using the more explicit image syntax suggested in the error message makes sense though. I've got that fix ready in #58.

Would anyone be willing to try using wpengine/github-action-wpe-site-deploy@fix-docker-image-syntax to make sure it addresses the issue?

Dimasmagadan commented 1 year ago

@apmatthews would that test give significant results? What if another runner would be used during such test?

May be it could make sense to specify a runner somehow? Github says, it is possible https://docs.github.com/en/actions/using-jobs/choosing-the-runner-for-a-job

apmatthews commented 1 year ago

@Dimasmagadan Sure, I can test with other runners to narrow down why a docker:// prefix seems to be only required in certain cases. Either way, adding the prefix appears to be the preferred approach, so if it resolves the issue as reported I think it's significant.

Are you specifying a runner in your workflow? If you can provide your full YML workflow config I'll be happy to test on my end.

Dimasmagadan commented 1 year ago

@apmatthews I've tested deploying with @fix-docker-image-syntax, pipeline finished correctly. I was using runs-on: ubuntu-latest

apmatthews commented 1 year ago

v3.2.2 has been released with the fix. v3.2 and v3 should also be working again.