JIRA Ticket

What Are We Doing Here

GHA currently uses an older version of both actions/checkout and Node. This PR updates to the newest versions we can use for both (considering transitive dependencies).

To install Node v20 using nvm, follow these steps:

Run nvm install v20
Start using v20 by running nvm use v20
To test your version, attempt running npm ci

Testing

Effectively testing compatibility for these dependency updates locally was tricky, but I was able to confirm several workflows ran checkout@v4 without errors.

Test e2e Deploy to WP Engine

act push -j run_action

Lint GHA Files

act push -j lint

The image used with act does not contain some packages available by default with GitHub, so both shellcheck and yamllint were installed as part of the workflow locally. The YAML for the job looked like this:

jobs:
  lint:
    runs-on: ubuntu-latest
    steps:
      - name: Lint files
        uses: actions/checkout@v4
      - name: Update package list
        run: sudo apt-get update
      - name: Install ShellCheck
        run: sudo apt-get install -y shellcheck
      - name: Install yamllint
        run: sudo apt-get install -y yamllint
      - run: echo "Running shell script lint!"
      - run: find . -name "*.sh" -type f | xargs -I {} shellcheck --severity=error {}
      - run: echo "Running yml file lint!"
      - run: find . -name "*.yml" -type f | xargs -I {} yamllint {}

Version and Release

I couldn't figure out a great way to test this workflow locally. changesets/action expects a valid GitHub token to run, but supplying a real token could actually create a PR or release while testing, which is not ideal 😄

At one point, I did try simply commenting out the step to create a PR. checkout@v4 and setup-node@v2 both seemed to work as expected and the current version was output by the job.

wpengine / github-action-wpe-site-deploy

[CICD-606] Update actions/checkout@v4, node v20 #98