search

wpeterman / ResistanceGA

Optimize resistance surfaces using Genetic Algorithms
36 stars 15 forks source link

Fix handling of 'precision' option for Circuitscape.jl #14

Closed ryanraaum closed 3 years ago

ryanraaum commented 3 years ago

Currently, it is impossible to invoke the single precision option of Circuitscape.jl from ResistanceGA following the documentation's guidance. When the value of precision is FALSE, "precision = None" is added to the .ini file. Circuitscape then reports "Precision: None", but I think it uses the default double precision. When the value of precision is TRUE, the option doesn't get added to the .ini file because the if-statement is testing "if(precision == 'single')". This pull request fixes that handling so that the single precision option can be invoked.

(I should have used a branch, but I so very rarely use git that I had forgot about that aspect of it. I can re-fork and create the change in a branch if you'd prefer.)

wpeterman commented 3 years ago

Thanks for bringing this to my attention, Ryan. It had fallen off my to do list to update. The latest version on GitHub should resolve this issue, although I didn't use your pull request.