Closed jeffreyhanson closed 7 years ago
Thanks, Jeff. I think you slogged deeper into my ugly coding than most.
In case you haven't seen it, a recent paper may be of interest given your initial email to me about overfitting.
http://onlinelibrary.wiley.com/doi/10.1002/ece3.2825/full
Bill Peterman Assistant Professor School of Environment and Natural Resources The Ohio State University 2021 Coffey Road Columbus, OH 43210-1085 Phone: 614.292.9795 Web Page https://goo.gl/4Gc15W Terrestrial Wildlife Ecology Lab http://www.twel.osu.edu
Bill Peterman
On Sat, Apr 22, 2017 at 11:42 PM, Jeff Hanson notifications@github.com wrote:
I've included the definitions for SCALE and SCALE.vector mentioned in #3 https://github.com/wpeterman/ResistanceGA/issues/3.
I've also updated DESCRIPTION with a new patch number (3.0-3), and added an entry to NEWS describing the patch.
I wasn't paying attention and my text editor also automatically removed the extra spaces in NEWS (80, 84, 118, 155). If this is an issue, I can refork your repo and make the changes again in a different editor so the extra spaces are still in.
You can view, comment on, or merge this pull request online at:
https://github.com/wpeterman/ResistanceGA/pull/4 Commit Summary
- fix #3, update news and version number
File Changes
- M DESCRIPTION https://github.com/wpeterman/ResistanceGA/pull/4/files#diff-0 (2)
- M NEWS https://github.com/wpeterman/ResistanceGA/pull/4/files#diff-1 (12)
- M R/internal_helper_functions.R https://github.com/wpeterman/ResistanceGA/pull/4/files#diff-2 (27)
Patch Links:
- https://github.com/wpeterman/ResistanceGA/pull/4.patch
- https://github.com/wpeterman/ResistanceGA/pull/4.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wpeterman/ResistanceGA/pull/4, or mute the thread https://github.com/notifications/unsubscribe-auth/AEa4UYoTgc8cO-p7o1ZxYlqZDUTIRyOeks5rysiUgaJpZM4NFSur .
No worries - thanks for implementing fix so quickly.
Yeah I hadn't seen that, thanks for the link.
I've included the definitions for
SCALE
andSCALE.vector
mentioned in #3.I've also updated DESCRIPTION with a new patch number (3.0-3), and added an entry to NEWS describing the patch.
I wasn't paying attention and my text editor also automatically removed the extra spaces in NEWS (lines 80, 84, 118, 155). If this is an issue, I can refork your repo and make the changes again in a different editor so the extra spaces are still in.