search

wpilibsuite / 2024Beta

Repository for Beta Testing of 2024 Software
32 stars 5 forks source link

Confusing dialog after installing vendordep #26

Closed chauser closed 9 months ago

chauser commented 10 months ago

After adding a new online vendor dep (CTRE in my case but I don't think it matters) a dialog box appears offering to build the project with choices "Yes" "No" and "Cancel". It is unclear what the "Cancel" option would do.

GrahamSH-LLK commented 10 months ago

It seems to do absolutely nothing, just close the dialog. However this cancel message does not come from us, it's part of VSCode. https://github.com/wpilibsuite/vscode-wpilib/blob/c850bd1e2dae631271ba3f880f208670f3f6ee11/vscode-wpilib/src/vendorlibraries.ts#L317

chauser commented 10 months ago

Thanks. Similar problem with the "Would you like to import this project into 2024?" dialog. Choices there are "No, Don't ask again", "No", "Cancel", "Yes".