CommandPS5Controller right joystick always returns -1

wpilibsuite / 2024Beta

Repository for Beta Testing of 2024 Software

32 stars 5 forks source link

CommandPS5Controller right joystick always returns -1 #43

Closed TapChap closed 9 months ago

TapChap commented 9 months ago

When using the methods getRightX() / getRightY() of a CommandPS5Controller object, the returned value is always stuck at -1.
in the Driverstation Joystick view, everything seems good,
I'm using a PS5 controller IRL (obviously)
CommandPS4Controller works fine

I don't have access to a robot at the moment, but If needed i'll have access to one this Sunday (to provide, pictures / log files / code etc)

ThadHouse commented 9 months ago

It looks like our mapping might be wrong. The triggers and the right stick are swapped. So getLeftTrigger() and getRightTrigger() seem to return what the right stick should be.

ThadHouse commented 9 months ago

Actually, my controller seems to completely match PS4 controller mappings.

https://github.com/wpilibsuite/allwpilib/pull/5257

Whoever was writing the PR did have different mappings for PS5 and PS4 controllers. So we need to figure out why.