wpilibsuite / PathWeaver

Desktop application for generating motion paths
Other
65 stars 68 forks source link

Reversed splines #185

Closed CarlinWilliamson closed 4 years ago

CarlinWilliamson commented 4 years ago

resolves #176

Adds the ability to plot reverse splines (where the robot drives backwards)

These are indicated by a dashed line and can be toggled using the right click menu on the waypoints.

CarlinWilliamson commented 4 years ago

Things I don't like here:

I should have access to a robot to test this in a few days.

My suggestion for fixing this boolean property issue would be to rework PathIOUtil to use json (so you can have properties for the path not the waypoints), move the right click menu to the spline and create a "path properties" menu. Looks like a fair bit of work... Perhaps it should go in a seperate PR? Thoughts?

Daltz333 commented 4 years ago

Your suggestions seem like a fair idea. Unfortunately, dev momentum on this project is pretty bare-bones. I would continue forward, and when it's ready for review, we can at least test the changes and see about merging then.

CarlinWilliamson commented 4 years ago

I did end up adding resverse splines to the "waypoint properties" menu. Tested it tonight and I'm happy with things.