wpilibsuite / SmartDashboard

Other
24 stars 28 forks source link

Bug fixes including choosers that don't appear and livewindow widgets that don't appear. #185

Closed chauser closed 11 months ago

chauser commented 1 year ago

Several significant changes and two rather cosmetic changes. Significant changes:

Cosmetic changes:

  1. When SmartDashboard is run with its stdout/stderr visible it produces a lot of uncaught java error index errors and tracebacks for choosers before the set of choices has been loaded.
  2. Similarly, when SmartDashboard does not have a LiveWindow widget for a device type (e.g. CANCoder and many others) it produces an uncaught null pointer error message and traceback. Although these errors are uncaught, they occur on single-use callback threads so they don't actually keep SmartDashboard from operating, but they are a major distraction when trying to work on actual problems. Resolves #184; #97 is related in that it mentions the stacktraces for unimplemented device types but it asks to have them implemented.
sciencewhiz commented 1 year ago

It feels like the disabling DS connection should be a separate PR, since that is a workaround that could hopefully be reenabled in the future.

sciencewhiz commented 1 year ago

It feels like disabling DS connection may also workaround #81

chauser commented 1 year ago

Yes. I've separated the DSClient change into a new branch and will make a new PR for it.

chauser commented 1 year ago

Yes. I've separated the DSClient change into a new branch and will make a new PR for it.

Changes to DSClient are back in this PR but as a delay in starting the DSClient until after the save file is processed, rather than completely disabling it. I think this will be satisfactory in providing both automatic connection and resolving the issue of things not appearing.