wpilibsuite / WPILibInstaller-Avalonia

Other
8 stars 20 forks source link

Consider enabling VS Code system certificates again #395

Closed sciencewhiz closed 6 months ago

sciencewhiz commented 7 months ago

We disabled using system certificates due to VS Code issues with LetsEncrypt, which have since been fixed. https://github.com/wpilibsuite/vscode-wpilib/issues/497

We should consider re-enabling it now that the issue has been fixed. Here's a CD thread that would likely be resolved if we used system certificates. https://www.chiefdelphi.com/t/cannot-download-revlib-due-to-certificate-chain/451721

https://github.com/wpilibsuite/WPILibInstaller-Avalonia/blob/8cb51768def8cd304ad8fdf18d53c9fac342817f/WPILibInstaller-Avalonia/ViewModels/InstallPageViewModel.cs#L314