search

wpilibsuite / WPILibPi

WPILib Raspberry Pi images designed for FRC (formerly FRCVision)
Other
87 stars 40 forks source link

Fix various places where username is hardcoded #122

Closed dfiel closed 3 years ago

dfiel commented 5 years ago

If one changes FIRST_USER_NAME in the config file to something other than pi, stage 4 will fail due to the hardcoding of the pi username. This PR changes the hardcoded pi username to reference the FIRST_USER_NAME variable. I have tested that this works in my own independent image. I am not sure if FIRST_USER_NAME is set to pi if it is unset in the config, if not that will have to be added.

dfiel commented 5 years ago

Found the problem again in the EXPORT-IMAGES stage. Fixed it with a second commit. I have also confirmed that the FIRST_USER_NAME environmental variable is set to pi by default, so this is a sane configuration change

dfiel commented 5 years ago

Found yet another place where the "pi" username is hardcoded