search

wpilibsuite / WPILibPi

WPILib Raspberry Pi images designed for FRC (formerly FRCVision)
Other
87 stars 40 forks source link

Line Endings - Need Correction On Import #92

Closed Sn3akyP3t3 closed 5 years ago

Sn3akyP3t3 commented 5 years ago

Code files passed over from client to the Pi via the interface should get their line endings corrected prior o execution. I suggest running dos2unix against uploads. Probably should do the same for the json import process if not done already.

ThadHouse commented 5 years ago

Are you using the 2019.2.1 update? This was fixed in that update.

Sn3akyP3t3 commented 5 years ago

I believe so, I downloaded the latest release image the night before opening the ticket.

PeterJohnson commented 5 years ago

Which application type are you using? Line endings are only converted for the "Uploaded Python file" application type.

Sn3akyP3t3 commented 5 years ago

It was Python. I got the image up and running now so I'll run a test and report my findings. I confirmed with my download folder that I'm using FRCVision_image-2019.2.1.zip's contents for the image.

Sn3akyP3t3 commented 5 years ago

Test revealed that line endings are LF and not CRLF after the upload. I can't recreate so it must be something I did that led to a false alarm. This one can be closed.