wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.05k stars 611 forks source link

Missing command templates for Conditional Command #1612

Closed sciencewhiz closed 10 months ago

sciencewhiz commented 5 years ago

There isn't a template for a ConditionalCommand in either wpilibjExamples or wpilibcExamples.

Starlight220 commented 4 years ago

What is wanted here? I see multiple options:

If this is resolved because of the command-based rewrite, close this.

AustinShalit commented 4 years ago

An example using ConditionalCommand

Do this one

sciencewhiz commented 3 years ago

A VS Code file generator template

This was the intent. VS Code pulls the templates from https://github.com/wpilibsuite/allwpilib/tree/master/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/commands

The FrisbeeBot example uses a ConditionalCommand, so that isn't needed.

Starlight220 commented 3 years ago

There are other command types that don't have a template:

However, not much use comes from overriding them...

rzblue commented 10 months ago

This PR isn't relevant anymore- in the new command library ConditionalCommand isn't intended to be subclassed.