Change to kSixInch etc to match the Style Guide and Stay Consistant

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC

https://wpilib.org/

Other

1.08k stars 611 forks source link

Change to kSixInch etc to match the Style Guide and Stay Consistant #3201

Closed jasondaming closed 3 years ago

jasondaming commented 3 years ago

https://github.com/wpilibsuite/allwpilib/blob/45590eea220923903606e47c7428939c3ce979e2/wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/DifferentialDrivetrainSim.java#L419

Should be: kFourInch(Units.inchesToMeters(4)), kSixInch(Units.inchesToMeters(6)), kEightInch(Units.inchesToMeters(8)), kTenInch(Units.inchesToMeters(10));

AustinShalit commented 3 years ago

This is actually not breaking - We can add a deprecated annotation to the members.