Unbuilt Source Files - Githubissues

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC

https://wpilib.org/

Other

1.06k stars 614 forks source link

Unbuilt Source Files #3357

Open pjreiniger opened 3 years ago

pjreiniger commented 3 years ago

Describe the question you have. I found some source files that are not build by gradle. I'll gladly help fix, but it should be up to you if it is actually dead code or something that should just be covered by the build system

cscore/java-examples - The cpp examples (cscore/examples`) are built, but these are not. They currently don't compile, but it is a trivial namespace change
ntcore/manualTests - SUPER old API's, I'm guessing these haven't been used in a while

PeterJohnson commented 3 years ago

The ntcore C++ manual tests are using recent APIs, but you are correct the Java ones are not. We should definitely fix the cscore java examples and build them.

pjreiniger commented 3 years ago

Also wpiutil/src/test/native/cpp/ManagedStaticTest.cpp - moving it builds fine, but fails testing on *nix