wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.08k stars 611 forks source link

Move LinearFilter, MedianFilter, and SlewRateLimiter to filter package #3395

Closed calcmogul closed 3 years ago

calcmogul commented 3 years ago

We have two in wpilibc/j and one in wpimath. In Java's case those two folders have different classpaths.

Starlight220 commented 3 years ago

So to which one should they be moved? I'm for the wpimath one.

calcmogul commented 3 years ago

Since they don't depend on ntcore, they should move to wpimath, if anywhere. I think one depends on frc2::Timer internally though.

calcmogul commented 3 years ago

I must have been looking at an old branch or something. Things got moved in #2629.