wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.06k stars 614 forks source link

StateSpaceSimTest is Missing State Space Sim Tests #3912

Open modelmat opened 2 years ago

modelmat commented 2 years ago

Describe the bug https://github.com/wpilibsuite/allwpilib/blob/main/wpilibc/src/test/native/cpp/simulation/StateSpaceSimTest.cpp only has the one test of flywheelSim. Add the rest.

To Reproduce Steps to reproduce the behavior:

  1. Watch intently at your screen and observe the existence of only one test
  2. Existential dread

Expected behavior There be tests.

Screenshots No.

modelmat commented 2 years ago

It seems that:

exist, so I think it would be better to rename StateSpaceSimTest to FlywheelSimTest and remove the includes.

Also Java doesn't have this test or the FlywheelSimTest

calcmogul commented 2 years ago

Yep. We should fix that.