wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.06k stars 614 forks source link

[ntcore] Restore fragmentation functionality #6189

Closed PeterJohnson closed 8 months ago

PeterJohnson commented 8 months ago

Fragmentation was disabled in #6149 due to a un-isolated bug. Once this bug is found and fixed, fragmentation should be restored, as the current lack of fragmentation increases the possibility of NT spurious disconnects due to large data items back-logging the connection.

PeterJohnson commented 8 months ago

There is no longer a strong reason to do this now that we use received byte time instead of ping response time to determine disconnect timeouts.