search

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.05k stars 612 forks source link

Proxy/Select Command inconsistency #6294

Open virtuald opened 7 months ago

virtuald commented 7 months ago

Why does ProxyCommand check for UB in isFinished but SelectCommand doesn't?

Starlight220 commented 7 months ago

As the call to isFinished is UB itself, whatever we do (or don't do) in the implementation isn't much of importance. For posterity we could check, but it's not violating any contracts.