Closed spacey-sooty closed 3 months ago
We can just use System.loadLibrary() where the old calls were. CombinedRuntimeLoader will not work for loading individual libraries.
RuntimeLoader.loadLibrary() might need to stay to give a better error message, but it'd be much simpler then what was already there.
We can just use System.loadLibrary() where the old calls were. CombinedRuntimeLoader will not work for loading individual libraries.
RuntimeLoader.loadLibrary() might need to stay to give a better error message, but it'd be much simpler then what was already there.
Based off debugging my typo in the AprilTagJNI I'd say the error message isn't that bad but they could be worse in different cases idk
Isn't the error message for raw loadLibrary() just "can't load native library"? I believe the reason we had the more descriptive error was for the (fairly common) case when users didn't have an updated MSVC runtime library installed.
Yes the error message is just can't load library name here if the updated MSVC runtime is an issue I can add back a simpler version of RuntimeLoader.loadLibrary()
Let’s do that, yes.
Do any vendor libraries use the removed functionality?
I don't think so. They shouldn't be doing so anyway if they are.
Resolves https://github.com/wpilibsuite/allwpilib/issues/6598