search

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.05k stars 611 forks source link

C++ command based examples don't all use CommandPtr #6601

Open spacey-sooty opened 3 months ago

spacey-sooty commented 3 months ago

This is best practice and should be enforced across examples.

rzblue commented 3 months ago

Related: https://github.com/wpilibsuite/allwpilib/issues/5921

spacey-sooty commented 3 months ago

I'm not 100% sure why that is closed as completed... it still appears to be true

ncorrea210 commented 3 months ago

This comment on #5988 is related to this post. It comes down to the usage of Command* and CommandPtr simply representing different ownership semantics in RobotContainer.