search

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.06k stars 614 forks source link

[wpilib] Make Java TimedRobot constructor public #6644

Closed calcmogul closed 4 months ago

calcmogul commented 4 months ago

It was changed from public to private in #781, which doesn't match TimesliceRobot or C++ TimedRobot.

ThadHouse commented 4 months ago

Protected here is fine. The derived class can still construct this.

calcmogul commented 4 months ago

In that case, we need to modify all the other classes to use protected for consistency.