wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.04k stars 606 forks source link

[wpilibj] Suppress this-escape warning on SharpIR #6659

Closed KangarooKoala closed 1 month ago

KangarooKoala commented 1 month ago

This was introduced by #6023, but for some reason the CI runs on main used the build cache for wpilibj:compileJava and did not get this error, and since our checkout step only checks out the commit that triggered the CI run (the default for actions/checkout) and the PR was based on an old version of main that was still on Java 11, the PR CI runs were with Java 11, which does not have the warning.

I'm concerned about the fact that this could happen (CI runs pass but local clean builds fail), but I'm not sure what the best fix for the root cause would be. (Figure out why the build cache was reused? Figure out how to avoid issues from PRs based on stale versions of main?)