wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.04k stars 606 forks source link

Add protected default constructor for CallbackStore. #6667

Closed brettle closed 1 month ago

brettle commented 1 month ago

This is to allow 3rd party sim providers (eg vendors) to subclass this class so that the register methods of their sim classes can return CallbackStores like the builtin sims.

Although it was already possible to create such a subclass but passing dummy parameters to one of the other constructors, this eliminates the need to pass such dummy parameters and makes it clearer that subclassing is allowed.

PeterJohnson commented 1 month ago

/format

PeterJohnson commented 1 month ago

Needs a formatting fix.