search

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.04k stars 606 forks source link

Mode-exit functions are missing from Robot.java in several templates #6678

Closed UserC2 closed 2 weeks ago

UserC2 commented 1 month ago

Describe the bug disabledExit(), teleopExit(), etc. functions are missing from Robot.java/Robot.cpp in the timed, timedskeleton, timeslice, timesliceskeleton and commandbased (but not commandbasedskeleton) templates.

Expected behavior These functions (along with explanatory comments in the non-skeleton templates) should be present.

Additional context Mode-exit functions added in #3499. Mode-exit functions added to commandbasedskeleton by #4861.

PeterJohnson commented 1 month ago

There's a bit of a tradeoff here. Generally teams don't need to use these. If they're present in the template, they're more discoverable, but add noise that may be distracting to inexperienced programmers.