wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.03k stars 606 forks source link

Upgrade to PMD 7.2.0 #6707

Closed Gold856 closed 3 weeks ago

Gold856 commented 4 weeks ago

Resolves #6597. Some notes on suppressions: SingularField was mostly suppressed in places where a Thread was created. I'm not sure whether or not the Thread object could actually be made completely local without unintended side effects from GC. I suppressed ExceptionAsFlowControl and AvoidThrowingNewInstanceOfSameException because we do both pretty frequently. Not sure if we'd prefer to refactor there. The spline classes explicitly create an array even though the method takes varargs. I assume it's a style thing, so I suppressed except for one spot in SplineHelper, since it was a 1D array of size 4.