search

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.03k stars 607 forks source link

[wpimath] remove WheelPositions interface/concept #6771

Open Alextopher opened 1 week ago

Alextopher commented 1 week ago

Closes #6706

KangarooKoala commented 1 week ago

You'll need to run Java formatting locally (./gradlew wpimath:spotlessApply), but otherwise looks good to me, for what it's worth.

Gold856 commented 1 week ago

Should this PR also remove/deprecate the copy methods left over from the WheelPositions interface on all the WheelPositions classes?

spacey-sooty commented 1 week ago

Should this PR also remove/deprecate the copy methods left over from the WheelPositions interface on all the WheelPositions classes?

imo yes