search

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.03k stars 607 forks source link

Trigger.onChange has no test #6777

Open spacey-sooty opened 6 days ago

KangarooKoala commented 5 days ago

What behavior do we want to test? For example, what is desired behavior of onTrue() if the Trigger condition starts true? (See #5608)

spacey-sooty commented 5 days ago

I think the behaviour of Trigger.onChange is easier to test see robotpys test https://github.com/robotpy/robotpy-commands-v2/commit/3eac469544fe1e8096dc20084bcd5f04448e62fc#diff-6d61aa359d85f8cd064c7b5a5ad419dacaec0575fe61e1ee86498c64037d5e4cR45

KangarooKoala commented 5 days ago

Oops, somehow I missed that this was specifically the onChange() method, not all of the trigger binding methods.