wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC

https://wpilib.org/

Other

1.06k stars 614 forks source link

[commands] Remove deprecated C++ method Command.TransferOwnership #6780

Closed spacey-sooty closed 3 months ago

github-actions[bot] commented 3 months ago

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

spacey-sooty commented 3 months ago

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

N/A here Python doesn't have the same ownership semantics

PeterJohnson commented 3 months ago

Needs a RobotBuilder PR to fix C++.

Starlight220 commented 3 months ago

I think the RobotBuilder check might be broken? Java is also failing, and this error is being printed: https://github.com/wpilibsuite/allwpilib/actions/runs/9713948699/job/26815947458#step:9:53

spacey-sooty commented 3 months ago

RobotBuilder shouldn't have been using this anyways its been deprecated since 2023

sciencewhiz commented 3 months ago

The RB failure should be unrelated because it failed both Java and C++ and this only changes C++

sciencewhiz commented 3 months ago

I think the RobotBuilder check might be broken? Java is also failing, and this error is being printed: https://github.com/wpilibsuite/allwpilib/actions/runs/9713948699/job/26815947458#step:9:53

That message is unrelated.

6783 should fix the failure