[build] Disable std::mutex constexpr constructor on Windows (again)

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC

https://wpilib.org/

Other

1.03k stars 607 forks source link

[build] Disable std::mutex constexpr constructor on Windows (again) #6791

Open rzblue opened 3 days ago

rzblue commented 3 days ago

Currently, artifacts are broken on a number of non-wpilib windows JVMs due to the JVM using an older redistributable.

ThadHouse commented 2 days ago

I had posted in Slack, but for others, this doesn't actually solve any problems. All this solves is the crash. However, using newer binaries with older runtimes is still problematic, as newer runtimes can include new symbols. The issue the user was seeing looked more like a missing symbol then the crash. Which this will never solve. The only way to solve that is to build in CI with an older runtime. Which isn't easily possible.