search

wpilibsuite / allwpilib

Official Repository of WPILibJ and WPILibC
https://wpilib.org/
Other
1.09k stars 611 forks source link

imgui libraries are not published #7241

Open Gold856 opened 1 month ago

Gold856 commented 1 month ago

We only publish headers and source. I'm not actually sure if we need to publish those libraries (are there any downstream consumers?) We should either remove publishing completely or publish native libraries.

virtuald commented 1 month ago

I would like to wrap the imgui/wpigui combination in python at some point, so I'll probably complain about that when I get to it.

There are various imgui python wrappers, but many are unmaintained or are out of date or only support some platforms.

PeterJohnson commented 1 month ago

I thought we statically linked the imgui libraries into the wpigui library--if that's not the case, we should definitely publish them.

Gold856 commented 1 month ago

I checked the wpigui libraries, and we do statically link imgui into wpigui. It's just that the headers and source for imgui are located elsewhere edu/wpi/first/thirdparty/imguiSuite/imguiSuite-cpp. It's a bit confusing though to have the headers split across two different places.