wpilibsuite / frc-characterization

Tools to help FRC teams measure the physical parameters of their robot
Apache License 2.0
51 stars 41 forks source link

Only use the needed vendor libraries #70

Open Daltz333 opened 4 years ago

Daltz333 commented 4 years ago

Generated projects should only use the vendordeps that it needs. It's not really feasible to expect every team to have vendor setups installed locally for things they don't use. Deleting the offending vendordep is a workaround, but not a solution

Oblarg commented 4 years ago

The vendordeps should auto-install, so this shouldn't be necessary; it still might be an okay improvement, I'm unsure if it's worth the extra duplication.

swalberg commented 4 years ago

FYI we're using an ADIS16448 so we added the JSON to vendordeps. Some library being brought in by navx_frc.json and REVRobotics.json was preventing the ADIS from being discovered ("can not find ADIS16448"). Deleted the superfluous JSON, rebuilt, and it's working.